Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Load kustomize_substitution values into environment variables in Tiltfile #6968

Closed
wants to merge 1 commit into from
Closed

🐛 Load kustomize_substitution values into environment variables in Tiltfile #6968

wants to merge 1 commit into from

Conversation

Jont828
Copy link
Contributor

@Jont828 Jont828 commented Jul 21, 2022

What this PR does / why we need it: Follow up to #6254 which fixes an issue where the kustomize_substitution values are not actually being loaded into the environment.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 21, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign justinsb for approval by writing /assign @justinsb in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 21, 2022
@Jont828
Copy link
Contributor Author

Jont828 commented Jul 21, 2022

@fabriziopandini @sbueringer @ykakarap Looks like I forgot to actually load the values from kustomize_substitutions here.

@Jont828 Jont828 changed the title Load kustomize_substitution values into environment variables 🐛 Load kustomize_substitution values into environment variables in Tiltfile Jul 22, 2022
ykakarap
ykakarap reviewed Jul 26, 2022
View reviewed changes
Copy link
Contributor

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, We probably wont need this with the improvements being added in #6984.

@Jont828 Jont828 mentioned this pull request Jul 28, 2022
Merged
@fabriziopandini
Copy link
Member

/close
this change has been incorporated in 6984; also opened tilt-dev/tilt#5910 to make things more straight forward

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: Closed this PR.

In response to this:

/close
this change has been incorporated in 6984; also opened tilt-dev/tilt#5910 to make things more straight forward

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykakarap ykakarap ykakarap left review comments

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@enxebre enxebre Awaiting requested review from enxebre

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jont828 @k8s-ci-robot @fabriziopandini @ykakarap